Messages in this thread | | | Subject | Re: [PATCH 1 of 3] Introduce __raw_memcpy_toio32 | From | Bryan O'Sullivan <> | Date | Wed, 11 Jan 2006 09:20:32 -0800 |
| |
On Tue, 2006-01-10 at 15:32 -0800, Andrew Morton wrote:
> Unless someone can think of a problem with attribute(weak), I think you'll > find that it's the simplest-by-far solution.
The only problem I can see with this is that on x86_64 and other platforms that reimplement the routine as an inline function, I think we'll be left with a small hunk of dead code in the form of the out-of-line version in lib/ that never gets referenced.
Is this something people care about? If so, I could turn the config setting in my last patch on its head, and use it to indicate that the routine should *not* be built for a particular arch. This would make lib/Makefile slightly uglier, but would avoid cluttering every other arch's lib/Makefile and Kconfig file.
<b
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |