lkml.org 
[lkml]   [2005]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 0/4] ide: Break ide_lock to per-hwgroup lock
    On Wed, Sep 07 2005, Ravikiran G Thirumalai wrote:
    > On Wed, Sep 07, 2005 at 11:19:24AM +0200, Jens Axboe wrote:
    > > On Tue, Sep 06 2005, Ravikiran G Thirumalai wrote:
    > > > The following patchset breaks down the global ide_lock to per-hwgroup lock.
    > > > We have taken the following approach.
    > >
    > > Curious, what is the point of this?
    > >
    >
    > On smp machines with multiple ide interfaces, we take per-group lock instead
    > of a global lock, there by breaking the lock to per-irq hwgroups.

    I realize the theory behind breaking up locks, I'm just wondering about
    this specific case. Please show actual contention data promoting this
    specific case, we don't break up locks "just because".

    I'm asking because I've never heard anyone complain about IDE lock
    contention and a proper patch usually comes with analysis of why it is
    needed.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-07 21:36    [W:0.019 / U:88.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site