lkml.org 
[lkml]   [2005]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] PCI: Unhide SMBus on Compaq Evo N620c
    On 9/6/05, Lee Revell <rlrevell@joe-job.com> wrote:
    > On Tue, 2005-09-06 at 13:39 -0700, Rumen Ivanov Zarev wrote:
    > > Trivial patch against 2.6.13 to unhide SMBus on Compaq Evo N620c laptop using
    > > Intel 82855PM chipset.
    >
    > > + } else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_COMPAQ)) {
    >
    > Should unlikely() be used for cases where the conditional will be true
    > iff a specific piece of hardware is present? Seems like we'd always
    > lose.
    >

    I would say that we should definitely not use [un]likely for code that
    is executed once during boot.

    --
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-07 01:04    [W:0.022 / U:1.780 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site