Messages in this thread | | | Date | Sun, 04 Sep 2005 18:55:51 +0200 | From | Jiri Slaby <> | Subject | Re: [ATMSAR] Request for review - update #1 |
| |
Giampaolo Tomassoni napsal(a):
>I attach a fixed version of the atmsar patch as a diff against the 2.6.13 kernel tree. > > static inline void dump_skb (char * prefix, unsigned int vc, struct sk_buff * skb) { what's this? 81+ chars on line { on a newline, please ' * ' --> ' *'
spin_lock_irqsave (&txq->lock, flags); indent is tab (tab is as long as 8 chars), no 3, 4, 5 or ... spaces
and many, many others, please read CodingStyle in Documentation.
thanks,
-- Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ jirislaby@gmail.com ~\-/~ 241B347EC88228DE51EE A49C4A73A25004CB2A10
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |