Messages in this thread | | | From | Stephen Hemminger <> | Subject | Re: reiser4 compilation fix [ was: 2.6.14-rc2-mm2] | Date | Fri, 30 Sep 2005 15:23:56 -0700 |
| |
> > Andrew, please add this reiser4 compilation fix : > --------------------------------------------------- > --- a/fs/reiser4/spin_macros.h > +++ b/fs/reiser4/spin_macros.h > @@ -82,8 +82,6 @@ typedef struct reiser4_rw_data { > static inline void spin_ ## NAME ## _init(TYPE *x) \ > { \ > __ODCA("nikita-2987", x != NULL); \ > - cassert(sizeof(x->FIELD) != 0); \ > - memset(& x->FIELD, 0, sizeof x->FIELD); \ > spin_lock_init(& x->FIELD.lock); \ > } \ > \ > @@ -236,7 +234,6 @@ typedef struct { int foo; } NAME ## _spi > static inline void rw_ ## NAME ## _init(TYPE *x) \ > { \ > __ODCA("nikita-2988", x != NULL); \ > - memset(& x->FIELD, 0, sizeof x->FIELD); \ > rwlock_init(& x->FIELD.lock); \ > } \ > \
These are just the kind of bogus macro's that block reiser4 from getting merged.
-- Stephen Hemminger <shemminger@osdl.org> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |