lkml.org 
[lkml]   [2005]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio


On Sat, 1 Oct 2005, Harald Welte wrote:
>
> please find the patch below. It compiles, but I didn't yet have the
> time to verify it makes the bug disappear and the async urb delivery is
> still working.

No, you can't re-use "check_kill_permissions()" like this, even though I
do understand the appeal.

The generic kill permissions check things like the current session, and
whether the caller has extra permissions, neither of which is sensible in
the context of "group_send_sig_info_as_uid()". So you do need to write out
the uid/euid checks separately, and have a different function for this
thing.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog