lkml.org 
[lkml]   [2005]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: SATA suspend/resume (was Re: [PATCH] updated version of Jens' SATA suspend-to-ram patch)
On Thu, Sep 29, 2005 at 08:34:37AM +0100, Christoph Hellwig wrote:
> is an ULDD operation, not an LLDD one, and this fits the layering model
> much better. The only complaints here are cosmetics:
>
> - generic_scsi_suspend/generic_scsi_resume are misnamed, they should
> probably be scsi_device_suspend/resume.
> - while we're at it they could probably move to scsi_sysfs.c to keep
> them static in one file - they're just a tiny bit of glue anyway.
> - get rid of all the CONFIG_PM ifdefs - it just clutters thing up far
> too much.

Actually one important thing is missing, that is a way to avoid spinning
down external disks. As a start a sysfs-controlable flag should do it,
later we can add transport-specific ways to find out whether a device
is external.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-29 10:14    [W:0.057 / U:0.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site