lkml.org 
[lkml]   [2005]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH 5/7] ppc64: EEH handle empty PCI slot failure
    From


    05-eeh-empty-slot-error.patch

    Performing PCI config-space reads to empty PCI slots can lead to reports of
    "permanent failure" from the firmware. Ignore permanent failures on empty slots.

    Signed-off-by: Linas Vepstas <linas@linas.org>

    Index: linux-2.6.14-rc2-git6/arch/ppc64/kernel/eeh.c
    ===================================================================
    --- linux-2.6.14-rc2-git6.orig/arch/ppc64/kernel/eeh.c 2005-09-29 16:06:25.583986100 -0500
    +++ linux-2.6.14-rc2-git6/arch/ppc64/kernel/eeh.c 2005-09-29 16:06:33.567867154 -0500
    @@ -617,7 +617,32 @@
    * In any case they must share a common PHB.
    */
    ret = read_slot_reset_state(pdn, rets);
    - if (!(ret == 0 && rets[1] == 1 && (rets[0] == 2 || rets[0] == 4))) {
    +
    + /* If the call to firmware failed, punt */
    + if (ret != 0) {
    + printk(KERN_WARNING "EEH: read_slot_reset_state() failed; rc=%d dn=%s\n",
    + ret, dn->full_name);
    + __get_cpu_var(false_positives)++;
    + return 0;
    + }
    +
    + /* If EEH is not supported on this device, punt. */
    + if (rets[1] != 1) {
    + printk(KERN_WARNING "EEH: event on unsupported device, rc=%d dn=%s\n",
    + ret, dn->full_name);
    + __get_cpu_var(false_positives)++;
    + return 0;
    + }
    +
    + /* If not the kind of error we know about, punt. */
    + if (rets[0] != 2 && rets[0] != 4 && rets[0] != 5) {
    + __get_cpu_var(false_positives)++;
    + return 0;
    + }
    +
    + /* Note that config-io to empty slots may fail;
    + * we recognize empty because they don't have children. */
    + if ((rets[0] == 5) && (dn->child == NULL)) {
    __get_cpu_var(false_positives)++;
    return 0;
    }
    @@ -650,7 +675,7 @@
    /* Most EEH events are due to device driver bugs. Having
    * a stack trace will help the device-driver authors figure
    * out what happened. So print that out. */
    - dump_stack();
    + if (rets[0] != 5) dump_stack();
    schedule_work(&eeh_event_wq);

    return 0;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-09-30 03:01    [W:0.023 / U:59.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site