lkml.org 
[lkml]   [2005]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] rio: switch to ANSI prototypes
On Thu, Sep 29, 2005 at 08:52:36PM +0400, Alexey Dobriyan wrote:
> On Thu, Sep 29, 2005 at 04:25:56PM +0100, Al Viro wrote:
> > Uh-oh... Well, if you want to play with it... FWIW, I'm disabling rio as
> > hopeless FPOS; if you feel masochistic, go ahead but keep in mind that its
> > handling of tty glue is severely b0rken.
>
> Well, duh... It clutters _my_ logs.

diff -urN RC13-git12-nfs-endian/drivers/char/Kconfig RC13-git12-rio/drivers/char/Kconfig
--- RC13-git12-nfs-endian/drivers/char/Kconfig 2005-09-10 15:41:34.000000000 -0400
+++ RC13-git12-rio/drivers/char/Kconfig 2005-09-12 14:50:05.000000000 -0400
@@ -282,12 +282,13 @@

config RIO
tristate "Specialix RIO system support"
- depends on SERIAL_NONSTANDARD && BROKEN_ON_SMP
+ depends on SERIAL_NONSTANDARD && BROKEN
help
This is a driver for the Specialix RIO, a smart serial card which
drives an outboard box that can support up to 128 ports. Product
information is at <http://www.perle.com/support/documentation.html#multiport>.
There are both ISA and PCI versions.
+ Note that while card might be smart, driver most certainly isn't.

config RIO_OLDPCI
bool "Support really old RIO/PCI cards"
had solved that one nicely for me (and that's the only driver that got
such treatment - this FPOS is really something special).

> > Use of caddr_t is *always* broken.
>
> "unsigned long arg" or do you keep in mind something more fundamental?

In this case - unsigned long, in other... Some are <something> __user *,
some are <something> __iomem *, some are simply void *...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-29 18:55    [W:0.044 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site