lkml.org 
[lkml]   [2005]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH][Fix] Fix Bug #4959 (take 2)
Date
Hi,

On Wednesday, 28 of September 2005 01:43, Pavel Machek wrote:
> Hi!
>
> > > > I can reserve the static buffer (10 pages) in suspend.c and mark it as nosave.
> > > > The code that creates the mappings can stay in suspend.c either except it
> > > > won't need to call get_usable_page() and free_eaten_memory() any more
> > > > (__next_page() can be changed to get pages from the static buffer instead
> > > > of allocating them). The code can also be simplified a bit, as we assume that
> > > > there will be only one PGD entry in the direct mapping.
> > > >
> > > > If that sounds good to you, please confirm.
> > >
> > > 8GB limit seems good to me -- as long as it makes code significantly
> > > simpler. It would be nice if it was <20 lines.
> >
> > It is more than that, but it seems to be quite simple anyway.
> >
> > The new patch follows.
>
> Thanks, seems okay to me.

Thanks for reviewing.

If you don't mind, I'll change arch_prepare_suspend() a bit so that the
RAM sizes are printed in KB and repost the patch with a changelog.

Greetings,
Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-28 10:36    [W:0.065 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site