[lkml]   [2005]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] remove check_region in drivers-char-specialix.c
    On Wed, Sep 28, 2005 at 06:52:44PM +0100, Al Viro wrote:
    > On Wed, Sep 28, 2005 at 10:37:37AM +0200, Borislav Petkov wrote:
    > > Hi Andrew,
    > >
    > > This is also a pretty simple case. We remove the wrapper and make
    > > sx__request_io_range return struct resource *. We check its value accordingly
    > > in the probing routine. It compiles cleanly here.
    > NAK. You've just introduced a pile of leaks - if sx_probe() fails after
    > that call, you end up with region claimed and not released.

    Andrew told me already today that Jeff[1] had sent a patch fixing all that. To
    prevent the leaks he's calling sx_release_io_range(bp) in every check before
    exiting sx_probe so this seems correct. A small question though: After calling
    sx_request_io_range() in the if-statement on line 499 is it ok to call
    sx_request_io_range() for a second time in a row on line 587? I think in
    this case the second call has to go, no?


    Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden:

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-09-29 00:30    [W:0.021 / U:16.128 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site