lkml.org 
[lkml]   [2005]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] remove check_region in drivers-char-specialix.c
    On Wed, Sep 28, 2005 at 06:52:44PM +0100, Al Viro wrote:
    > On Wed, Sep 28, 2005 at 10:37:37AM +0200, Borislav Petkov wrote:
    > > Hi Andrew,
    > >
    > > This is also a pretty simple case. We remove the wrapper and make
    > > sx__request_io_range return struct resource *. We check its value accordingly
    > > in the probing routine. It compiles cleanly here.
    >
    > NAK. You've just introduced a pile of leaks - if sx_probe() fails after
    > that call, you end up with region claimed and not released.

    Andrew told me already today that Jeff[1] had sent a patch fixing all that. To
    prevent the leaks he's calling sx_release_io_range(bp) in every check before
    exiting sx_probe so this seems correct. A small question though: After calling
    sx_request_io_range() in the if-statement on line 499 is it ok to call
    sx_request_io_range() for a second time in a row on line 587? I think in
    this case the second call has to go, no?

    [1]rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git





    ___________________________________________________________
    Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-29 00:30    [W:0.022 / U:1.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site