Messages in this thread | | | Date | Wed, 28 Sep 2005 16:04:55 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH 1/3] Add disk hotswap support to libata RESEND #5 |
| |
Lukasz Kosewski wrote: > No. ata_device_add returns nonzero on success; so say the docs.
Whoops, you're right. I forget it was special.
> Since the return value is not checked here, and whether on success or > failure all of the data structures allocated in that method stick > around, I assumed that something was in the works for this. I'll > change this to kfree(hp) on returning 0. Please advise if I should do > something else.
It still needs to clean up after pdc_host_init()...
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |