lkml.org 
[lkml]   [2005]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [uml-devel] Re: [RFC] [patch 0/18] remap_file_pages protection support (for UML), try 3
Date
On Wednesday 28 September 2005 15:37, Hugh Dickins wrote:
> Sorry, it's really hard to read your interspersed comments. Perhaps I
> need to switch on some colour option when reading your mails, but I've
> never found the need for it before. Please, use a blank line above
> and below your comments to help us locate them and read them, thanks.

Ok, will do.

> On Mon, 26 Sep 2005, Blaisorblade wrote:
> > On Wednesday 07 September 2005 14:00, Hugh Dickins wrote:
> > > So far as I can see (I may have missed it), you really don't need to
> > > change from the write boolean
> > >
> > > (perhaps -1 for exec in one arch??)
> >
> > ? Not understood this part, ignoring it?
> > Maybe you mean "except one arch, x86_64, which supports exec protection?"
>
> No, I meant the current code uses "0" for read fault, "1" for write fault,
> and (in a quick search) only found one architecture (I forget which,
> certainly not x86_64) which might have been interested to pass down
> a different value to handle_mm_fault to distinguish execution fault:
> for which I was suggesting to use "-1", rather than change everywhere.

In my local tree I've restricted the changes to generic arch code, and to
x86_64 which uses the __handle_mm_fault with VM_EXEC if needed. The rest keep
using handle_mm_fault (there's still the check for VM_MANYPROTS).

> Though now I'm doubting there was any such case at all.

> Hugh

--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade





___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-28 18:23    [W:0.186 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site