Messages in this thread Patch in this message | | | Date | Tue, 27 Sep 2005 07:42:23 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: bogus VIA IRQ fixup in drivers/pci/quirks.c |
| |
On Tue, 27 Sep 2005, Stian Jordet wrote: > > He wanted me to test 2.6.12-rc2-mm3, which actually disabled irq9 as > well at boottime. After some debugging, he made this patch, which made > irq 9 work as normal again for me. Please don't back this patch out, > without at least re-looking at my system.
Well, looking at your messages, I bet that the appended patch works for you, since your irq's are all in the legacy range.
It is also conceptually closer to what the code _used_ to be (it used to say "if we have an IO-APIC, don't do this", now it says "if this irq is bound to an IO-APIC, don't do this")
Whether this will matter to Olaf, I don't know, but the old code was definitely just writing random bits for the IO-APIC case afaik.
Linus
--- diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -546,7 +546,10 @@ static void quirk_via_irq(struct pci_dev { u8 irq, new_irq; - new_irq = dev->irq & 0xf; + new_irq = dev->irq; + if (!new_irq || new_irq >= 15) + return; + pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq); if (new_irq != irq) { printk(KERN_INFO "PCI: Via IRQ fixup for %s, from %d to %d\n", - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |