Messages in this thread | | | Date | Sun, 25 Sep 2005 08:20:31 +0200 | From | Willy Tarreau <> | Subject | Re: [patch] sys_epoll_wait() timeout saga ... |
| |
Hi Andrew,
On Sat, Sep 24, 2005 at 11:05:45PM -0700, Andrew Morton wrote: > Davide Libenzi <davidel@xmailserver.org> wrote: > > > > The attached patch uses the kernel min() macro, that is optimized has > > single compare by gcc-O2. Andrew, this goes over (hopefully ;) the bits > > you already have in -mm. > > OK, well I've rather lost the plot with all the patches flying around. > > I now have one single patch against epoll.c, below. Please confirm that > this is what was intended. If not, I'll drop it and let's start again.
Well, this one is fine. However, since there are possible overflows in msec_to_jiffies() that I fixed in another patch, it would be cleaner to only rely on this function's ability to detect overflows. Moreover, using this function removes the divide for most common values of HZ, which is interesting on some archs.
As Davide mentionned it, the EP_MAX_MSTIMEO constant would be useful for other parts of the kernel (starting with sys_poll()). That's also what my fix to jiffies.h does.
If you don't feel comfortable with so much changes at once, it's better to first apply Davide's fix, then later the jiffies one, and then after, I could resend the ep_poll() and sys_poll() patches to use the functions in jiffies.h instead of doing their own magics.
Regards, Willy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |