Messages in this thread | | | From | Denis Vlasenko <> | Subject | Re: New inventions in rounding up in catc.c? | Date | Sun, 25 Sep 2005 13:43:47 +0300 |
| |
On Saturday 24 September 2005 21:46, Grant Coady wrote: > On Sat, 24 Sep 2005 13:43:42 +0300, Denis Vlasenko <vda@ilport.com.ua> wrote: > > /* F5U011 only does one packet per RX */ > > if (catc->is_f5u011) > > break; > >- pkt_start += (((pkt_len + 1) >> 6) + 1) << 6; > >+ pkt_start += ((pkt_len + 2) + 63) & ~63; > > pkt_start += ((pkt_len + 1) + 64) & ~63; > > Seems more clear to me.
Why?
((pkt_len + 2) + 63) & ~63 is "add 2 and round up to next 64". ((pkt_len + 1) + 64) & ~63 is "???!"
It's strange code anyway, I hope maintainer can clarify what's going on. (I suspect it was intended to be pkt_len - 1, not +, in the first place) -- vda - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |