lkml.org 
[lkml]   [2005]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/3] fuse: check O_DIRECT
    From
    Date
    > > +	/* VFS checks this, but only _after_ ->open() */
    > > + if (file->f_flags & O_DIRECT)
    > > + return -EINVAL;
    > > +
    > > err = generic_file_open(inode, file);
    > > if (err)
    > > return err;
    >
    > This hardly seems worth optimising for?

    It could be a correctness issue too: if filesystem has open() with
    side effect, then it should fail before doing the open, not after.

    Not a big deal, but I think it's worth the 3 lines.

    Miklos
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-24 07:59    [W:0.019 / U:0.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site