lkml.org 
[lkml]   [2005]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC][PATCH] inline a few tiny functions in init/initramfs.c
    Date
    On Sat, 24 Sep 2005 09:26, Jesper Juhl wrote:
    > A few functions in init/initramfs.c are so simple that I don't see why
    > *any* point in them having to bear the cost of a function call.
    > Wouldn't something like the patch below make sense ?

    > -static void __init *malloc(size_t size)
    > +static inline void __init *malloc(size_t size)
    > {
    > return kmalloc(size, GFP_KERNEL);

    maybe it looks like it would, but kmalloc looks like this:

    85 static inline void *kmalloc(size_t size, int flags)
    86 {
    87 if (__builtin_constant_p(size)) {
    88 int i = 0;
    89 #define CACHE(x) \
    90 if (size <= x) \
    91 goto found; \
    92 else \
    93 i++;
    94 #include "kmalloc_sizes.h"
    95 #undef CACHE
    96 {
    97 extern void __you_cannot_kmalloc_that_much(void);
    98 __you_cannot_kmalloc_that_much();
    99 }
    100 found:
    101 return kmem_cache_alloc((flags & GFP_DMA) ?
    102 malloc_sizes[i].cs_dmacachep :
    103 malloc_sizes[i].cs_cachep, flags);
    104 }
    105 return __kmalloc(size, flags);
    106 }

    which is not a one liner to inline at all

    > -static void __init free(void *where)
    > +static inline void __init free(void *where)
    > {
    > kfree(where);

    kfree ok since it's a void function of its own

    > static __initdata char *header_buf, *symlink_buf, *name_buf;
    >
    > -static int __init do_start(void)
    > +static inline int __init do_start(void)
    > {
    > read_into(header_buf, 110, GotHeader);

    read_into ok as well.

    Cheers,
    Con
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-24 06:18    [W:0.021 / U:34.932 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site