lkml.org 
[lkml]   [2005]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/3] lib/string.c cleanup : remove pointless register keyword
Date
Removes a few pointless  register  keywords. register is merely a compiler 
hint that access to the variable should be optimized, but gcc (3.3.6 in my
case) generates the exact same code with and without the keyword, and even
if gcc did something different with register present I think it is doubtful
we would want to optimize access to these variables - especially since this
is generic library code and there are supposed to be optimized versions in
asm/ for anything that really matters speed wise.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

lib/string.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.14-rc2-git3/lib/string.c-with-patch-1 2005-09-23 22:44:42.000000000 +0200
+++ linux-2.6.14-rc2-git3/lib/string.c 2005-09-23 22:45:35.000000000 +0200
@@ -219,7 +219,7 @@ EXPORT_SYMBOL(strlcat);
#undef strcmp
int strcmp(const char *cs, const char *ct)
{
- register signed char __res;
+ signed char __res;

while (1) {
if ((__res = *cs - *ct++) != 0 || !*cs++)
@@ -239,7 +239,7 @@ EXPORT_SYMBOL(strcmp);
*/
int strncmp(const char *cs, const char *ct, size_t count)
{
- register signed char __res = 0;
+ signed char __res = 0;

while (count) {
if ((__res = *cs - *ct++) != 0 || !*cs++)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-23 23:52    [W:0.060 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site