Messages in this thread | | | Date | Thu, 22 Sep 2005 23:54:13 -0700 (PDT) | Subject | Re: making kmalloc BUG() might not be a good idea | From | "David S. Miller" <> |
| |
From: Nick Piggin <nickpiggin@yahoo.com.au> Date: Fri, 23 Sep 2005 16:30:33 +1000
> David S. Miller wrote: > > >I'm sort-of concerned about this change: > > > > [PATCH] __kmalloc: Generate BUG if size requested is too large. > > > >it opens a can of worms, and stuff that used to generate > >-ENOMEM kinds of failures will now BUG() the kernel. > > > >Unless you're going to audit every user triggerable > >path for proper size limiting, I think we should revert > >this change. > > Making it WARN might be a good compromise.
It's a better, but it's still turning a harmless -ENOMEM into a DoS log file filler for the cases where a size limit check is missing and is user triggerable.
Another idea is to put it under CONFIG_DEBUG or something. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |