[lkml]   [2005]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: init and zap low address mappings on demand for cpu hotplug
Ashok Raj <> wrote:
> +/*
> + * mode
> + * 0 indicates its for __cpu_up to kick an AP into boot sequence.
> + * 1 indicates completion os smp boot process, so we can zap the low
> + * until there is need to bring a cpu up again.
> + */
> +__cpuinit void zap_low_mappings(int mode)

grump. `mode' is a terrible identifier name. Better to call it something
which identifies its meaning if true, such as `do_mapping_zapping' or

Even better, implement two nicely-named functions rather than passing in a
`mode' argument. Those functions can of course share a common
mode-selected implementation internally.

And that comment is incomprehensible, partly due to all its typos. Care to
try again?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-09-21 23:15    [W:0.054 / U:113.696 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site