Messages in this thread | | | Date | Wed, 21 Sep 2005 15:19:13 -0400 | From | Bill Davidsen <> | Subject | Re: [PATCH 08/10] uml: Fix GFP_ flags usage |
| |
Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> > > GFP_ATOMIC | GFP_KERNEL is meaningless and won't work. Actually it never worked, > even in 2.4. > > Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> > --- > > arch/um/kernel/process_kern.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/um/kernel/process_kern.c b/arch/um/kernel/process_kern.c > --- a/arch/um/kernel/process_kern.c > +++ b/arch/um/kernel/process_kern.c > @@ -82,7 +82,8 @@ unsigned long alloc_stack(int order, int > unsigned long page; > int flags = GFP_KERNEL; > > - if(atomic) flags |= GFP_ATOMIC; > + if (atomic) > + flags = GFP_ATOMIC; > page = __get_free_pages(flags, order); > if(page == 0) > return(0); >
int flags = (atomic ? GFP_ATOMIC : GFP_KERNEL);
-- -bill davidsen (davidsen@tmr.com) "The secret to procrastination is to put things off until the last possible moment - but no longer" -me
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |