Messages in this thread | | | Subject | Re: [PATCH] Keys: Add possessor permissions to keys | From | Trond Myklebust <> | Date | Wed, 21 Sep 2005 13:47:14 -0400 |
| |
on den 21.09.2005 Klokka 10:15 (-0700) skreiv Andrew Morton:
> > + if (PTR_ERR(key_ref) != -EAGAIN) { > > + if (IS_ERR(key_ref)) > > + key = key_deref(key_ref); > > + else > > + key = ERR_PTR(PTR_ERR(key_ref)); > > + break; > > + } > > + } > > That's getting a bit intimate with how IS_ERR and PTR_ERR are implemented > but I guess we're unlikely to change that.
Shouldn't that test for IS_ERR(key_ref) be inverted?
Cheers, Trond
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |