lkml.org 
[lkml]   [2005]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: GFS, what's remaining
    On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:

    > + gfs2_assert(gl->gl_sbd, atomic_read(&gl->gl_count) > 0,);

    > what is gfs2_assert() about anyway? please just use BUG_ON directly
    > everywhere

    When a machine has many gfs file systems mounted at once it can be useful
    to know which one failed. Does the following look ok?

    #define gfs2_assert(sdp, assertion) \
    do { \
    if (unlikely(!(assertion))) { \
    printk(KERN_ERR \
    "GFS2: fsid=%s: fatal: assertion \"%s\" failed\n" \
    "GFS2: fsid=%s: function = %s\n" \
    "GFS2: fsid=%s: file = %s, line = %u\n" \
    "GFS2: fsid=%s: time = %lu\n", \
    sdp->sd_fsname, # assertion, \
    sdp->sd_fsname, __FUNCTION__, \
    sdp->sd_fsname, __FILE__, __LINE__, \
    sdp->sd_fsname, get_seconds()); \
    BUG(); \
    } \
    } while (0)

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-02 11:40    [W:0.034 / U:1.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site