lkml.org 
[lkml]   [2005]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Au1x00 8250 uart support.
Date
On Monday 19 September 2005 23:44, Christoph Hellwig wrote:
> > static _INLINE_ unsigned int serial_in(struct uart_8250_port *up, int offset)
> > {
> > +#ifdef CONFIG_SERIAL_8250_AU1X00
> > + if (up->port.iotype == UPIO_AU)
> > + offset = au_io_in_map[offset];
> > +#endif
>
> All this ifdef stuff is rather messy. Allowing the driver to specity a map
> in some structure might make more sense.
>
>

Sure, I can do that.

But the check for the map existence will take a couple of instructions then,
for all architectures. If you're fine with that, it'd be no problem.

Regards

Pantelis
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-19 22:54    [W:0.171 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site