[lkml]   [2005]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: 2.6.14-rc1-git-now still dying in mm/slab - this time line 1849
Christoph Lameter <> wrote:
> On Mon, 19 Sep 2005, Andrew Morton wrote:
> > Well. The CPU_UP_CANCELED locking in cpuup_callback() looks borked to me -
> > it takes cachep->nodelists[node]->list_lock and then calls
> > drain_alien_cache() which appears to take the same lock. But that's not
> > the problem here.
> >
> > The code in cache_reap() recalculates numa_node_id() multiple times, so if
> > the caller changes CPUs then this assertion will trigger. However it's
> > running under keventd here, which is pinned to a single CPU. Still, it
> > would be useful if you could try putting preempt_disable()s in
> > cache_reap(), or change cache_reap() to evaluate numa_node_id() just the
> > once, and cache that in a local variable.
> drain_array_cache_locked calls check_spinlock_acquired_node which is in
> turn insuring that interrupts are off. So no move to a different processor
> should be possible.

list_for_each(walk, &cache_chain) {
kmem_cache_t *searchp;
struct list_head* p;
int tofree;
struct slab *slabp;

searchp = list_entry(walk, kmem_cache_t, next);

if (searchp->flags & SLAB_NO_REAP)
goto next;


l3 = searchp->nodelists[numa_node_id()];
if (l3->alien)
drain_alien_cache(searchp, l3);
->preempt here

drain_array_locked(searchp, ac_data(searchp), 0,
->oops, wrong node.

Still, this should all be pinned to one CPU, by happenstance.

> However, that is contradicted by __wake_up calling
> drain_array_cache_locked. The process just woke up?

Not sure what you mean here.

> > I wonder why numa_node_id() uses raw_smp_processor_id()? That's just
> > asking for preempt non-atomicity bugs.
> Accessing arrays indexed by node number even works if the process
> continues to be executed on another node.

That's a special case and the callers should be changed to use a new
raw_numa_node_id() in that case.

Code which calls numa_node_id() and then continues to use the result of
that in preemptible code is often buggy. Code which reevaluates
numa_node_id() in preemptible code and assumes that it returned the same
thing is even buggier (unless it happens to be CPU pinned).

numa_node_id() is doing a bad thing and should be converted to use
smp_processor_id() so we can identify all the possibly-buggy callsites.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-09-19 21:32    [W:0.134 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site