Messages in this thread | | | Date | Thu, 15 Sep 2005 11:51:24 +1000 | From | Nick Piggin <> | Subject | Re: [PATCH 2/5] atomic: introduce atomic_inc_not_zero |
| |
Russell King wrote:
> The whole point about architecture specific includes is not to provide > a frenzied feeding ground for folk who like to "clean code up" but to > allow architectures to do things in the most efficient way for them > without polluting the kernel too much. > > It seems that aspect is being lost sight of here. >
Yep. We've got atomic_add, atomic_sub, atomic_inc, atomic_dec, atomic_inc_return, atomic_add_return, atomic_dec_return, atomic_sub_return to start with.
Not only that, but we can probably emulate all the atomic_ operations with atomic_cmpxchg, not just atomic_inc_not_zero.
Roman: any ideas about what you would prefer? You'll notice atomic_inc_not_zero replaces rcuref_inc_lf, which is used several times in the VFS.
Thanks, Nick
-- SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |