Messages in this thread | | | Date | Thu, 15 Sep 2005 03:04:24 +1000 | From | Nick Piggin <> | Subject | Re: [PATCH 2/5] atomic: introduce atomic_inc_not_zero |
| |
Nick Piggin wrote: > Roman Zippel wrote: > >> Hi, >> >> On Thu, 15 Sep 2005, Nick Piggin wrote: >> >> >>> Also needs work on those same architectures. Other architectures >>> might want to look at providing a more optimal implementation. >> >> >> >> IMO a rather pointless primitive, unless there is a cpu architecture >> which has a inc_not_zero instruction, otherwise it will always be the >> same as using cmpxchg. >> >
[snip]
But even supposing the cmpxchg variant was the highest performing implementation available on any architecture, I would still consider exporting the inc_not_zero instruction.
The reason is that cmpxchg is not nearly so readable as inc_not_zero when used inline in the code.
-- SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |