lkml.org 
[lkml]   [2005]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kbuild-permanently-fix-kernel-configuration-include-mess.patch added to -mm tree
> That is a small price to pay, rather than having to continually maintain
> "does this file need config.h included" - which I think can conclusively
> be shown to be a total lost cause. There are about 3450 configuration
> include errors in the kernel as of -git last night.
Depends on how you count...
If all .h files followed the rule - they should be selfcontained. In
other words they should all include what they need this is correct.

The correct figure is much less.
I did a check with defconfig for i386.
There are 7 .o files where config.h is not included - all are correct.
lib/errno.c, arch/ia386/boot/bootsect.S + a few more.
That was out of 983 .o files.

There will be no slowdown introducing -iinclude (or -imacros) keeping
these figures in mind.



find -name '.*.o.cmd' | xargs grep __KERNEL__ to find number of .o files
build.

added grep -l 'include/linux/config.h' to find .o files build and where
config-h was included. Then a simple diff..

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-14 19:26    [W:0.041 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site