Messages in this thread | | | Date | Wed, 14 Sep 2005 09:26:50 -0700 (PDT) | Subject | Re: [patch 2.6.14-rc1] pci: only call pci_restore_bars at boot | From | "David S. Miller" <> |
| |
From: Jeff Garzik <jgarzik@pobox.com> Date: Wed, 14 Sep 2005 11:08:12 -0400
> This seems like it will break a lot of stuff that -does- need the BARs > restored when resuming from D3.
I wasn't going to say anything about this ia64 workaround, but yes I have to agree with Jeff, this change starts to lose the whole point of the original change.
Why in the world can a PCI device not handle it's BARs being rewritten, especially if we're just rewriting the same exact values it had when we probed it beforehand?
IA64 could handle the necessary cases in it's PCI config space access methods. Ugly, but keeps the core clean and limits the avoidance to the cases that really truly cannot handle the BAR rewrites. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |