Messages in this thread | | | Date | Tue, 13 Sep 2005 15:07:37 -0700 | From | Ravikiran G Thirumalai <> | Subject | Re: [patch 9/11] net: dst_entry.refcount, use, lastuse to use alloc_percpu |
| |
On Tue, Sep 13, 2005 at 01:24:42PM -0700, David S. Miller wrote: > > There is no way in the world this enormous amount of NUMA > complexity is being added to the destination cache layer.
Agreed the dst changes are ugly; that can be worked on. But the cacheline bouncing problem on the atomic_t dst_entry refcounter has been around for quite a while -- even on SMPs, not just NUMA. We need a solution for that. I thought you were against the dst_entry bloat caused by the previous version of the dst patch. alloc_percpu takes that away. You had concerns about workloads with low route locality. Unfortunately we don't have access to infrastructure setup for such tests :(
As for the ugliness, would something on the lines of net_device refcounter patch in the series above be acceptable?
Thanks, Kiran - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |