Messages in this thread | | | Date | Tue, 13 Sep 2005 10:21:57 -0700 | From | Greg KH <> | Subject | Re: [PATCH 3/5] isicom: pci probing |
| |
On Tue, Sep 13, 2005 at 06:52:56PM +0200, Jiri Slaby wrote: > Signed-off-by: Jiri Slaby <xslaby@fi.muni.cz> > > drivers/char/isicom.c | 598 +++++++++++++++++++++++++++---------------------- > include/linux/isicom.h | 3 > 2 files changed, 333 insertions(+), 268 deletions(-) > > diff --git a/drivers/char/isicom.c b/drivers/char/isicom.c > --- a/drivers/char/isicom.c > +++ b/drivers/char/isicom.c > @@ -91,6 +91,8 @@ > * 06/01/05 Alan Cox Merged the ISI and base kernel strands > * into a single 2.6 driver > * > + * 10/09/05 Jiri Slaby driver rewritten to 2.6 API > + *
The git changelog works well enough that you don't need to add stuff to the files themselves anymore.
> +#define InterruptTheCard(base) outw(0, (base) + 0xc) > +#define ClearInterrupt(base) inw((base) + 0x0a) > + > +#ifdef ISICOM_DEBUG > +#define pr_deb(str, ...) printk((str), ##args); > +#define isicom_paranoia_check(a, b, c) __isicom_paranoia_check((a), (b), (c)) > +#else > +#define pr_deb(str, ...) > +#define isicom_paranoia_check(a, b, c) 0 > +#endif
This doesn't look like "pci probe changes" In fact, a lot of other changes in this patch don't look like them either...
Care to split it up even more?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |