Messages in this thread | | | Date | Tue, 13 Sep 2005 15:08:26 +0100 | From | Russell King <> | Subject | Re: Missing #include <config.h> |
| |
On Tue, Sep 13, 2005 at 02:56:23PM +0100, Jörn Engel wrote: > After spending some hours last night and this morning hunting a bug, > I've found that a different include order made a difference. Some > files don't work correctly, unless config.h is included before.
I'm still of the opinion that we should add
-imacros include/linux/config.h
to the gcc command line and stop bothering with trying to get linux/config.h included into the right files and not in others. (which then means we can eliminate linux/config.h from all files.)
From what you can see below, missing includes of it can remain for months, and it can cause bugs which are rather non-obvious.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |