lkml.org 
[lkml]   [2005]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpuset semaphore depth check optimize
Paul Jackson <pj@sgi.com> wrote:
>
> +static struct task_struct *cpuset_sem_owner;
> +static int cpuset_sem_depth;
>
> /*
> * The global cpuset semaphore cpuset_sem can be needed by the
> @@ -200,16 +202,19 @@ static DECLARE_MUTEX(cpuset_sem);
>
> static inline void cpuset_down(struct semaphore *psem)
> {
> - if (current->cpuset_sem_nest_depth == 0)
> + if (cpuset_sem_owner != current) {
> down(psem);
> - current->cpuset_sem_nest_depth++;
> + cpuset_sem_owner = current;
> + }
> + cpuset_sem_depth++;
> }

Better, but still hacky. The rest of the kernel manages to avoid the need
for nestable semaphores by getting the locking design sorted out. Can
cpusets do that sometime?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-12 13:44    [W:3.584 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site