lkml.org 
[lkml]   [2005]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] nfs client, kernel 2.4.31: readlink result overflow
From
Date
On Mon, 12 Sep 2005 15:37:46 EDT, Assar said:
> Valdis.Kletnieks@vt.edu writes:
> > Odd, as it has similar code - 2.6.13-mm1 nfs2xdr.c has:
> > /* Convert length of symlink */
> > len = ntohl(*p++);
> > if (len >= rcvbuf->page_len || len <= 0) {
>
> To my reading, the 2.6.13 code does not copy the 4 bytes of length to
> rcvbuf.

Hmm... it still does this:
kaddr[len+rcvbuf->page_base] = '\0';
which still has a possible off-by-one? (Was that why you have -1 -4?)

> > Am I the only one who finds an uncommented "-1 -4" construct scary beyond belief?
>
> Probably not. What do you think looks better? sizeof(u32) ?

sizeof(actual_var) is even better, as that way it's clear what you're allowing
space for.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-09-12 22:04    [W:0.045 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site