lkml.org 
[lkml]   [2005]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/base/class.c: fix swapped memset() arguments
Alexey Dobriyan napsal(a):

>Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>---
>
> drivers/base/class.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>--- linux-vanilla/drivers/base/class.c
>+++ linux-memset/drivers/base/class.c
>@@ -506,7 +506,7 @@ int class_device_add(struct class_device
> kobject_del(&class_dev->kobj);
> goto register_done;
> }
>- memset(attr, sizeof(*attr), 0x00);
>+ memset(attr, 0x00, sizeof(*attr));
> attr->attr.name = "dev";
> attr->attr.mode = S_IRUGO;
> attr->attr.owner = parent->owner;
>
>
Consider use of kzalloc, some of latest git snapshot contains it yet.
Maybe you want to replace all occurences of memset in this source with
that as I took a look.

--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-12 20:26    [W:0.024 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site