lkml.org 
[lkml]   [2005]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [GIT PATCH] More PCI patches for 2.6.13
    Date
    On Sunday 11 September 2005 05:41, Greg KH wrote:
    > On Sat, Sep 10, 2005 at 11:32:54PM +0100, Alistair John Strachan wrote:
    > > On Saturday 10 September 2005 22:58, Jeff Garzik wrote:
    > > > Linus Torvalds wrote:
    > > > > Case closed.
    > > > >
    > > > > Bogus warnings are a _bad_ thing. They cause people to write buggy
    > > > > code.
    > > > >
    > > > > That drivers/pci/pci.c code should be simplified to not look at the
    > > > > error return from pci_set_power_state() at all. Special-casing EIO is
    > > > > just another bug waiting to happen.
    > > >
    > > > As a tangent, the 'foo is deprecated' warnings for pm_register() and
    > > > inter_module_register() annoy me, primarily because they never seem to
    > > > go away.
    > > >
    > > > The only user of inter_module_xxx is CONFIG_MTD -- thus the deprecated
    > > > warning is useless to 90% of us, who will never use MTD. As for
    > > > pm_register(), there are tons of users remaining. As such, for the
    > > > forseeable future, we will continue to see pm_register() warnings and
    > > > ignore them -- thus they are nothing but useless build noise.
    > > >
    > > > I've attached a patch, just tested, which addresses inter_module_xxx by
    > > > making its build conditional on the last remaining user. This solves
    > > > the deprecated warning problem for most of us, and makes the kernel
    > > > smaller for most of us, at the same time.
    > >
    > > Though external modules using these functions will be hung out to dry.
    >
    > External modules are always hung out to dry. Seriously, you don't have
    > code using those functions, do you? If so, it's not like you haven't
    > been warned...

    I don't care, and no I don't. I was just making the point before somebody
    makes the mistake of doing something that isn't 100% clear cut.

    Either you remove it, or you don't. You don't leave it there for some distros
    to enable with CONFIG_MTD and some not.

    --
    Cheers,
    Alistair.

    'No sense being pessimistic, it probably wouldn't work anyway.'
    Third year Computer Science undergraduate.
    1F2 55 South Clerk Street, Edinburgh, UK.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-11 08:54    [W:0.021 / U:13.828 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site