lkml.org 
[lkml]   [2005]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [GIT PATCH] More PCI patches for 2.6.13


    On Sat, 10 Sep 2005, Jeff Garzik wrote:
    >
    > I -do- want to use iomap. The problem is that no one has yet come up
    > with a few that does all the proper resource reservation. Everybody
    > (including myself) did the ioread/iowrite part, but gave up before
    > handling all cases of (a) legacy ISA iomap, (b) native PCI IDE iomap,
    > and (c) non-standard MMIO iomap.

    It should all be trivial. The only ugly issue in the patch I just sent out
    is that it needs to save the "legacy_mode" bits that were calculated at
    initialization time somewhere in the ap structure. Then the
    release_regions should match the request_regions.

    That's a cleanup, the current code is literally buggy. It may end up
    releasing IO address 0x1f0 twice, if somebody wasn't marked legacy, but
    actually had 0x1f0 in the PCI resource pointers (maybe that doesn't ever
    happen, but still.. Relying on the legacy-value of the IO port instead of
    relying on whether you did a legacy request_region() is definitely at
    least conceptually wrong).

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-18 23:46    [W:2.104 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site