Messages in this thread Patch in this message | | | Date | Sat, 10 Sep 2005 23:00:46 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH 2.6] hwmon: via686a: save 0.5k by long v[256] -> s16 v[256] |
| |
Hi Greg,
> Unfortunatly, no one noticed that this patch adds a build warning :(
I'm sorry about that, I though I had checked but now it seems not. A new patch addressing the issue follows.
Thanks.
----------------------
We can save 0.5kB of data in the via686a driver.
From: Denis Vlasenko <vda@ilport.com.ua> Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/hwmon/via686a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.13-git7.orig/drivers/hwmon/via686a.c 2005-09-08 22:40:16.000000000 +0200 +++ linux-2.6.13-git7/drivers/hwmon/via686a.c 2005-09-10 10:56:12.000000000 +0200 @@ -198,7 +198,7 @@ but the function is very linear in the useful range (0-80 deg C), so we'll just use linear interpolation for 10-bit readings.) So, tempLUT is the temp at via register values 0-255: */ -static const long tempLUT[] = +static const s16 tempLUT[] = { -709, -688, -667, -646, -627, -607, -589, -570, -553, -536, -519, -503, -487, -471, -456, -442, -428, -414, -400, -387, -375, -362, -350, -339, -327, -316, -305, -295, -285, -275, -265, @@ -270,7 +270,7 @@ } /* for 8-bit temperature hyst and over registers */ -#define TEMP_FROM_REG(val) (tempLUT[(val)] * 100) +#define TEMP_FROM_REG(val) ((long)tempLUT[val] * 100) /* for 10-bit temperature readings */ static inline long TEMP_FROM_REG10(u16 val)
-- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |