lkml.org 
[lkml]   [2005]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 6/7] uml: avoid already done dirtying
    The PTE returned from handle_mm_fault is already marked as dirty and accessed
    if needed.
    Also, since this is not set with set_pte() (which sets NEWPAGE and NEWPROT as
    needed), this wouldn't work anyway.

    This version has been updated and fixed, thanks to some feedback from Jeff Dike.

    Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    ---

    arch/um/kernel/trap_kern.c | 3 +--
    1 files changed, 1 insertions(+), 2 deletions(-)

    diff --git a/arch/um/kernel/trap_kern.c b/arch/um/kernel/trap_kern.c
    --- a/arch/um/kernel/trap_kern.c
    +++ b/arch/um/kernel/trap_kern.c
    @@ -85,8 +85,7 @@ survive:
    pte = pte_offset_kernel(pmd, address);
    } while(!pte_present(*pte));
    err = 0;
    - *pte = pte_mkyoung(*pte);
    - if(pte_write(*pte)) *pte = pte_mkdirty(*pte);
    + WARN_ON(!pte_young(*pte) || (is_write && !pte_dirty(*pte)));
    flush_tlb_page(vma, address);
    out:
    up_read(&mm->mmap_sem);
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-10 20:06    [W:0.018 / U:4.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site