lkml.org 
[lkml]   [2005]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [Hotplug_sig] [patch 1/1] Hot plug CPU to support physical add of new processors (i386)
Date
From
> Protasevich, Natalie wrote:
> > > > +#ifdef CONFIG_HOTPLUG_CPU
> > > > + if (cpu_online(cpu)) {
> > > > +#else
> > > > if (cpu_online(cpu) || !cpu_present(cpu)) {
> > > > +#endif
> > > > ret = -EINVAL;
> > > > goto out;
> > > > }
> > >
> > > Why this change? I think the cpu_present check is needed for
> > > ppc64 since it has non-present cpus in sysfs.
> > >
> >
> > The new processor was never brought up, its bit is only set in
> > cpu_possible_map, but not in present map.
>
> If a cpu is physically present and is capable of being
> onlined it should be marked in cpu_present_map, please. This
> change would break ppc64; can you rework it?
>
OK, that has to be reworked then. That's what probably Shaohua meant
when mentioned that cpu_present_map has to be cleaned up...
Thanks,
--Natalie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-01 18:06    [W:0.107 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site