lkml.org 
[lkml]   [2005]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] MPC8xx PCMCIA driver

    Thu, Sep 01, 2005 at 10:53:19AM +0200, Dominik Brodowski wrote:
    > Hi,
    >
    > On Mon, Aug 29, 2005 at 11:48:40PM -0300, Marcelo Tosatti wrote:
    > > Russell: The driver is using pccard_nonstatic_ops for card window
    > > management, even though the driver its marked SS_STATIC_MAP (using
    > > mem->static_map).
    >
    > This is obviously broken. Where does it fail if pccard_static_ops is used?

    IIRC pcmcia_request_io() fails to dynamically allocate IO windows for PCMCIA
    cards because find_io_region returns NULL.

    OTOH, as Magnus noted, the memory windows are static:

    * Because of the lacking offset register we must map the whole card.
    * We assign each memory window PCMCIA_MEM_WIN_SIZE address space.
    * Make sure there is (PCMCIA_MEM_WIN_SIZE * PCMCIA_MEM_WIN_NO
    * * PCMCIA_SOCKETS_NO) bytes at PCMCIA_MEM_WIN_BASE.
    * The i/o windows are dynamically allocated at PCMCIA_IO_WIN_BASE.
    * They are maximum 64KByte each...

    socket[i].socket.features = SS_CAP_PCCARD | SS_CAP_MEM_ALIGN | SS_CAP_STATIC_MAP;
    socket[i].socket.io_offset = 0;

    > > +typedef struct {
    > > + u_int regbit;
    > > + u_int eventbit;
    > > +} event_table_t;
    >
    > No typedefs, please.

    OK, will fix.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-01 17:00    [W:2.523 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site