Messages in this thread | | | Date | Tue, 09 Aug 2005 23:15:51 +1000 | From | Nick Piggin <> | Subject | Re: [RFC][patch 0/2] mm: remove PageReserved |
| |
Hugh Dickins wrote: > On Tue, 9 Aug 2005, Nick Piggin wrote:
>>But in either case: I agree that it is probably not a great loss >>to remove the check, although considering it will be needed for >>swsusp anyway... > > > swsusp (and I think crashdump has a similar need) is a very different > case: it's approaching memory from the zone/mem_map end, with no(?) idea > of how the different pages are used: needs to save all the info while > avoiding those areas which would give trouble. I can well imagine it > needs either a page flag or a table lookup to decide that. >
Yep.
> But ioremap and remap_pfn_range are coming from drivers which (we hope) > know what they're mapping these particular areas for. If it's provable > that the meaning which swsusp needs is equally usable for a little sanity > check in ioremap, okay, but I'm sceptical. >
I understand what you mean, and I agree. Though as far away from the business end of the drivers I am, I tend to get the feeling that drivers need the most hand holding.
Anyway, I guess the way to understand the problem is finding the reason why ioremap checks PageReserved, and whether or not ioremap should be expected (or allowed) to remap physical RAM in use by the kernel.
-- SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |