Messages in this thread Patch in this message | | | Date | Tue, 9 Aug 2005 00:44:41 -0400 | From | Dave Jones <> | Subject | Incorrect permissions on parport sysctls. |
| |
We have a bunch of 'probe' sysctl's in parport, which are readable. (world readable even). Make them write-only. Without this, sysctl -a will try to read these files.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.11/drivers/parport/procfs.c~ 2005-04-25 12:17:30.000000000 -0400 +++ linux-2.6.11/drivers/parport/procfs.c 2005-04-25 12:20:35.000000000 -0400 @@ -286,19 +286,19 @@ static const struct parport_sysctl_table PARPORT_DEVICES_ROOT_DIR, #ifdef CONFIG_PARPORT_1284 { DEV_PARPORT_AUTOPROBE, "autoprobe", - NULL, 0, 0444, NULL, + NULL, 0, 0200, NULL, &do_autoprobe }, { DEV_PARPORT_AUTOPROBE + 1, "autoprobe0", - NULL, 0, 0444, NULL, + NULL, 0, 0200, NULL, &do_autoprobe }, { DEV_PARPORT_AUTOPROBE + 2, "autoprobe1", - NULL, 0, 0444, NULL, + NULL, 0, 0200, NULL, &do_autoprobe }, { DEV_PARPORT_AUTOPROBE + 3, "autoprobe2", - NULL, 0, 0444, NULL, + NULL, 0, 0200, NULL, &do_autoprobe }, { DEV_PARPORT_AUTOPROBE + 4, "autoprobe3", - NULL, 0, 0444, NULL, + NULL, 0, 0200, NULL, &do_autoprobe }, #endif /* IEEE 1284 support */ {0} - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |