lkml.org 
[lkml]   [2005]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH C&C] gdth: remove GDTIOCTL_OSVERS
On Mon, Aug 08, 2005 at 03:40:27AM +0200, Adrian Bunk wrote:
> On Mon, Aug 08, 2005 at 02:28:29AM +0400, Alexey Dobriyan wrote:
> > - case GDTIOCTL_OSVERS:
> > - {
> > - gdth_ioctl_osvers osv;
> > -
> > - osv.version = (unchar)(LINUX_VERSION_CODE >> 16);
> > - osv.subversion = (unchar)(LINUX_VERSION_CODE >> 8);
> > - osv.revision = (ushort)(LINUX_VERSION_CODE & 0xff);
> > - if (copy_to_user(argp, &osv, sizeof(gdth_ioctl_osvers)))
> > - return -EFAULT;
> > - break;
> > - }

> Not that I'd like this, but you know that this is a userspace-visible
> change?

I know. I also know about uname(2), /proc/sys/kernel/osrelease,
/proc/version, uname(1).

OK, I'll schedule it for removal and give a #warning. How much time
will be enough with everyone? For the record: IMO, it should be zero in
this particular case.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-08 12:28    [W:0.036 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site