Messages in this thread | | | Date | Sun, 7 Aug 2005 21:37:08 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 1/1] i386 Encapsulate copying of pgd entries |
| |
Hi!
> Since most hypervisors will likely provide a suspend/resume mechanism > that is external to the guest, most of this is a moot point anyways.
Ok.
> But I wondered if you thought the pgd_clone() accessor would make this > cleaner or if it is just most confusing: > > #ifdef CONFIG_SOFTWARE_SUSPEND > /* > * Swap suspend & friends need this for resume because things like the > intel-agp > * driver might have split up a kernel 4MB mapping. > */ > char __nosavedata swsusp_pg_dir[PAGE_SIZE] > __attribute__ ((aligned (PAGE_SIZE))); > > static inline void save_pg_dir(void) > { > memcpy(swsusp_pg_dir, swapper_pg_dir, PAGE_SIZE); <--- could be > clone_pgd_range() > }
Yep, clone_pgd_range would make sense here... Pavel
-- if you have sharp zaurus hardware you don't need... you know my address - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |