lkml.org 
[lkml]   [2005]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] s390: fix invalid kmalloc flags
On Fri, Aug 05, 2005 at 05:36:29PM -0700, Andrew Morton wrote:
> No, GFP_DMA should work OK. Except GFP_DMA doesn't have __GFP_VALID set.
> It's strange that this didn't get noticed earlier.
>
> Ben, was there a reason for not giving GFP_DMA the treatment?

Not really. Traditionally GFP_DMA was always mixed in with GFP_KERNEL or
GFP_ATOMIC. It seems that GFP_DMA wasn't in the hunk of defines that all
the other kernel flags were in, so if GFP_DMA is really valid all by itself,
adding in the __GFP_VALID should be okay.

-ben
--
"Time is what keeps everything from happening all at once." -- John Wheeler
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-06 04:04    [W:0.032 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site