Messages in this thread | | | Subject | Re: [PATCH] IPMI driver update part 1, add per-channel IPMB addresses | From | Arjan van de Ven <> | Date | Thu, 04 Aug 2005 15:35:09 +0200 |
| |
> >Be aware that this function will use more stack space than it needs to: gcc > >will create a separate stack slot for all the above locals. > > > >Hence it would be better to declare them all at the start of the function. > >Faster, too - less dcache footprint. > > > >Maybe not as nice from a purist point of view, but it does allow you to > >lose those braces in the switch statement... > > > > > Hmm, I assumed that gcc would optimize and allocate the stack as it > needed it without waste. Ok, easy enough to fix.
latest gcc does the right thing; older gcc don't though.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |