Messages in this thread | | | Date | 4 Aug 2005 12:43:02 +0200 | Date | Thu, 4 Aug 2005 12:43:02 +0200 | From | Andi Kleen <> | Subject | Re: [patch 4/8] x86_64:Fix cluster mode send_IPI_allbutself to use get_cpu()/put_cpu() |
| |
On Mon, Aug 01, 2005 at 01:20:21PM -0700, Ashok Raj wrote: > Need to ensure we dont get prempted when we clear ourself from mask when using > clustered mode genapic code.
It's not needed I think. If the caller wants to execute code on the current CPU then it has to have disabled preemption itself already to avoid races. And if not it doesn't care.
One could argue that this function should be always called with preemption disabled though. Perhaps better a WARN_ON().
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |