Messages in this thread | | | From | Con Kolivas <> | Subject | Re: [PATCH] no-idle-hz aka dynamic ticks-2 | Date | Fri, 5 Aug 2005 10:05:27 +1000 |
| |
On Fri, 5 Aug 2005 10:02 am, Con Kolivas wrote: > On Thu, 4 Aug 2005 07:09 am, Pavel Machek wrote: > > Hi! > > > > > > > As promised, here is an updated patch for the newly released > > > > > 2.6.13-rc5. Boots and runs fine on P4HT (SMP+SMT kernel) built with > > > > > gcc 4.0.1. > > > > > > > > Doesn't compile for me w/ gcc 3.4.4: > > > > > > Thanks for the report. Tiny change required. Here is a respun patch. > > > > I'm not sure if you added them, but... > > > > CC arch/i386/kernel/timers/timer_tsc.o > > arch/i386/kernel/timers/timer_tsc.c: In function `mark_offset_tsc': > > arch/i386/kernel/timers/timer_tsc.c:345: warning: `lost' might be used > > uninitialized in this function arch/i386/kernel/timers/timer_tsc.c:345: > > warning: `delay' might be used uninitialized in this function > > arch/i386/kernel/timers/timer_tsc.c:347: warning: `count' might be used > > uninitialized in this function > > Indeed the goto will bypass the setting of these variables and they will be > uninitialised. Will fix with next version, thanks.
Looking yet further into this, if it gotos monotonic_base it will return without using any of these variables so it's a harmless warning but we may as well initialise them to quieten it.
Cheers, Con - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |